Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

experimental end round voting #4559

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

experimental end round voting #4559

wants to merge 12 commits into from

Conversation

Trilbyspaceclone
Copy link
Collaborator

Voting for round end now needs a 60% majority to be vaild
Every vote that fails lowers the needed majority by 10%
The end round vote is no longer callable
Round end now auto calls 4 hours in and then again every hour untill 8 hours into a round
Adds a supper majority end round, for people to call cooldown 30 mins to stop spaming

@Trilbyspaceclone Trilbyspaceclone added Documentation Improvements or additions to documentation Balance Improves on fairness labels Mar 14, 2023
@Trilbyspaceclone Trilbyspaceclone added the Test Merged A RP that is test merged before added to the code itself label Mar 14, 2023
@king5327
Copy link
Contributor

king5327 commented Apr 3, 2023 •
edited
Loading

I can't allow this to be merged until the hardcoded round timer is removed.

For whatever reason, an admin accidentally started an endround vote at the beginning of the round and then four hours later the round said it was 'eight hours had passed.'

@king5327 king5327 added the Unintended Something isn't working as intended label Apr 3, 2023
@REDLAERT88
Copy link
Contributor

REDLAERT88 commented Apr 10, 2023 •
edited
Loading

This has worked quite well as an idea. I think its good we full merge this. Though as stated the system has minor bugs. Some of which like the round end thing are timer issues, which can be a bit of a hassle to resolve.

@Guidesu
Copy link
Contributor

Guidesu commented Apr 10, 2023

Sheep headmin here personally okay with it.

@king5327 king5327 added the DO NOT MERGE Do not merge label Apr 10, 2023
@king5327
Copy link
Contributor

As soon as I'm done with the ticket system I'm going to be adjusting this PR and manually merging it.

@cdb-is-not-good
Copy link
Collaborator

As soon as I'm done with the ticket system I'm going to be adjusting this PR and manually merging it.

6 months later.

@ChefDoggo
Copy link
Contributor

As soon as I'm done with the ticket system I'm going to be adjusting this PR and manually merging it.

unfathomably real (he fucking lied)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shadow-Quill Shadow-Quill Shadow-Quill left review comments

Assignees
No one assigned
Labels
Balance Improves on fairness DO NOT MERGE Do not merge Documentation Improvements or additions to documentation Test Merged A RP that is test merged before added to the code itself Unintended Something isn't working as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trilbyspaceclone @king5327 @REDLAERT88 @Guidesu @cdb-is-not-good @ChefDoggo @Shadow-Quill